> A lot of Egypt's economy is overseas aid from the US and similar.

The rest is fees from the Panama (EDIT: Suez) Canal and tourism. Getting into a war, particularly with a country on the Red Sea, is suicide. (Also, the main flash point between Egypt and Ethipia has receded since the GERD finished filling.)