logoalt Hacker News

solarmistlast Thursday at 5:54 PM1 replyview on HN

I loved the idea of code reviews interviews, i've had several good ones, until yesterday when I had my first bad code review interview.

They asked me to review a function for a residential housing payment workflow, which I'm unfamiliar with. From an actual snippet of their bad production code (which has since been rewritten). In Go which I've never used (I've never professionally used the language that doesn't have error handling built-in, for example).

I had to spend more than half of my time asking questions to try and get enough context about Go error handling techniques, the abstractions they were using which we only had the import statements to and the way that the external system was structured to handle these requests to review the hundred lines of code they shared.

I was able to identify a bunch of things incidentally, like making all of the DB changes as part of a transaction so that we don't get inconsistent state or breaking up the function into sub functions, because the names were extremely long, but this was so far outside my area of expertise and comfort zone that I felt like shooting in the dark.

So just like any other interview style, they can be done very poorly.


Replies

typewithrhythmlast Thursday at 9:31 PM

Honestly this sounds like a successful "bad fit" signal (assuming that they work with go and payment systems mostly).

Language and domain experience are things id like to know after an interview process.

show 1 reply