They don’t even necessarily have positive benefits for manufacturers unless they somehow have a supply chain that exists only in the US all the way down. The automakers are against tariffs, for example.
This may kill more manufacturing than it creates.