logoalt Hacker News

throwaway150today at 3:19 PM1 replyview on HN

All of this makes sense. Thank you for explaining. I don't think I understand the difference though.

Like are they calling the "GitHub pull request" workflow as the push model? What is "push" about it though? I can download all the pull request patches to my local and work offline, can't I?


Replies

bayindirhtoday at 3:22 PM

GitHub pull request pushes you a notification/e-mail to handle the merge, and you have to handle the pull request mostly online.

I don't know how you can download the pull request as a set of patches and work offline, but you have to open a branch, merge the PR to that branch, test the things and merge that branch to relevant one.

Or you have to download the forked repository, do your tests to see the change is relevant/stable whatnot and if it works, you can then merge the PR.

---

edit: Looks like you can get the PR as a patch or diff, and is trivial, but you have to be online again to get it that way. So, getting your mails from your box is not enough, you have to get every PR as a diff, with a tool or manually. Then you have to organize them. e-mails are much more unified and simple way to handle all this.

---

In either case, reviewing the changes is not possible when you're offline, plus the pings of the PRs is distracting, if your project is popular.

show 2 replies