I think the point isn't if it's been a good decision at the time (I don't think it's been much of a decision at all), but rather that Russia wouldn't have invaded Ukraine, if Ukraine was still armed with nuclear weapons. Hindsight is 20/20, but the world took notice.
Are 20 year unmaintained weapons an effective deterent? Would there have been capacity to resist occupation if it wasn't? Would Ukraine have been coerced into some form of union through economic means and would that be better or worse for the people of Ukraine than the invasions?
All sorts of questions to ask. Yes, if our timeline was otherwise unchanged, but the nukes were kept and maintained, it seems unlikely that invasion in 2014 would have happened... But it's a big change to the timeline to keep the weapons, and there's too many unknowns to predict the resulting changes. I do strongly suspect few countries will accept similar assurances in the future, unless under duress, but then Ukraine wasn't exactly free from duress at the time either.