logoalt Hacker News

hartatorlast Wednesday at 5:58 PM2 repliesview on HN

I think they are misreading the situation.

The devil is in the details. It seems `getHeaders` v. `headers` is non-security, non-performance related issue. Why people should spend time fixing these?


Replies

attractivechaoslast Wednesday at 9:11 PM

Even if getHeaders() has security/performance concerns, the better solution is to make it an alias to the newer headers.get() in this case. Keeping the old API is a small hassle to a handful of developers but breaking existing code puts a much bigger burden on a lot more users.

show 1 reply
CaliforniaKarllast Wednesday at 6:11 PM

If you (either directly or from SerpApi) are supporting the urllib3 folks (through a Tidelift subscription), then yes, that is a valid point.

Otherwise, I'd say that's a very brave comment you are making.

show 2 replies