Why isn't Russia torturing him to get all the secrets out of him?
Because real life is not a Bond movie where the first thing that happens is a British actor with a bad Russian accent starts torturing you like in Goldfinger.
Plus, as the US has found out, torture has been proven a bad way to get the truth out of people, since under duress people will admit and say anything just to make the pain stop, even if they're innocent and have no valuable information.
Because they already had everything he could provide and the embarrassment weights far more then some tiny details they could get by torturing him.
He's much more useful being the ultimate tankie online
There already did? And or little to get since he didn't memorize secrets and most--if not all--his digital copies were given to the press?
It's doubtful Snowden was in possession of his NSA data dump at the time he arrived to Moscow, the things he had memorized would have been of very limited value.
If the Russian government was in possession of his data, I'd consider it fairly surprising that they seemingly never leaked any of the materials.
While it's not strictly impossible that Snowden through the Russian Government was the "second source", given that all the leaks from the second source came after Snowden had landed in Moscow, none of the "second source" files were included within the Snowden dump a bunch of journalists have access to. There are also various more specific reasons to belive that Snowden probably would not have had access to all the things originating from the second source, and even more so many of the things originating from TSB.
Same is true of Snowden possibly being TSB, whether or not "second source" and the TSB were the one and the same. It's just not really credible.
Here's a good starting point if you're not familiar with the second source https://www.electrospaces.net/2017/09/are-shadow-brokers-ide...