> Isn’t that a bit like raising your kid with the intent of playing in the NBA though?

Not quite. NBA is for a tiny minority a a great well paying career. Most parents who raise their kids to play in the NBA will fail in that goal. However if you instead make the goal get a great scholarship playing basketball which is then used to pay for the degree that becomes their career it can be a great plan.

However here it sounds like the sailing was done not to get a great career, but to get a great college scholarship. This is likely a great plan. I suspect that while there are more basketball scholarships than sailing scholarships, there is a lot less competition for the sailing ones. It wouldn't surprise me if the typical sailing scholarship was higher than the typical basketball one - if you want someone on your team you need to get them away from the other schools, while for basketball if someone isn't obvious NBA bound (and thus your star starter) if they go elsewhere you just pick the next kid on the list for the scholarship.

The above isn't just sports. In music Violin vs Bassoon gets the same issues. Acting also fits in somehow. And your kids may well be doing more than one of the above.

> I’ve seen far more of my helicopter-parented high-performance peers burn out

I've seen a lot of kids burn out from all backgrounds. The real problem I see with helicopter is because the kids never get to make mistakes they don't learn how to deal with them. The less controlled kids learn to be a little cautious and so when they rebel they are not going to go as far.