logoalt Hacker News

distancesyesterday at 11:18 PM1 replyview on HN

That smells of bad team practices. Put a practical limit on PRs sizes as the first step, around 500 lines max is a good rule of thumb in my experience. Larger than that, and the expectation then is a number of small PRs to a feature branch.

I rarely see a PR that should pass without comments. Your team is being sloppy.


Replies

mullingitovertoday at 1:06 AM

> Your team is being sloppy.

I'm talking about a running joke in the industry, not my team.