> Isn’t that a bit like raising your kid with the intent of playing in the NBA though?

No: getting to the NBA is very difficult, but you don't have to be that good. You 'just' have to be good enough to play at the college/university level with a scholarship. One doesn't necessarily have to 'go pro'.

I knew someone who got a scholarship to a business/finance program for cross-country running: he wasn't planning on being a pro runner. And doing these activities in high school is probably a good thing, from a social and health perspective, regardless of if it leads anywhere else.