> made their redactions with actual ink, and then re-scanned every page
That's not very competent.
> going analog is foolproof
Absolutely not. There are many way's to f this up. Just the smallest variation in places that have been inked twice will reveal the clear text.
I suppose the best process would be this, and then after rescanning putting a black bar over each redacted text with image editing.
> Just the smallest variation in places that have been inked twice will reveal the clear text
Sure. But anyone can visually examine this. That means everyone with situational context can directly examine the quality of the redaction.
Contrast that with a digital redation. You have to trust the tool works. Or you have to separate the folks with context from the folks with techical competence. (There is the third option of training everyone in the DoJ how to examine the inner workings of a PDF. That seems wasteful.)