logoalt Hacker News

swinglock • yesterday at 2:28 PM • 4 replies • view on HN

I'm surprised curlx_strcopy doesn't return success. Sure you could check if dest[0] != '/0' if you care to, but that's not only clumsy to write but also error prone, and so checking for success is not encouraged.

Replies

jutter • yesterday at 3:05 PM

This is especially bizarre given that he explains above that "it is rare that copying a partial string is the right choice" and that the previous solution returned an error...

So now it silently fails and sets dest to an empty string without even partially copying anything!?

AlexeyBrin • yesterday at 2:40 PM

I guess the idea is that if the code does not crash at this line:

    DEBUGASSERT(slen < dsize);
it means it succeeded. Although some compilers will remove the assertions in release builds.

I would have preferred an explicit error code though.

➕ show 1 reply
ahoka • today at 12:05 AM

Yeah, thought the same. Expect some CVEs in the future.

➕ show 1 reply