I’m an em-dash lover but always (and still do) type the double hyphen because that’s what I was taught for APA style years ago