Pessimists think nothing is worth doing, and are frequently right. But they will never catch the occasional thing that is worth doing. Some of the optimists will.

But optimism favors action, while pessimism favors inaction. And action vastly (and compoundingly) increases the amount of opportunities for being right.

Pessimists are just as often wrong too! Clearly the person you're replying to is an "optimist". :)

To be clear, I don't think there's a strong correlation between being rich and being a pessimist/optimist.

And to your original point, being right cannot possibly be biased towards optimism or pessimism. Any apparent correlation is more of a reflection on what everyone else thinks... and they are wrong! Cheers to being right!