Okay, so aggressive taxation should then have its (proven) benefits weighed against the (dubious) benefits of having 30% of your millionaires change their legal residence to be elsewhere.

I think taxes still handily win with room to spare. Even more: plenty of those rich people are still in NY and participating in its economy (legal residence != where you actually physically live, especially if you have resources to game residence by owning multiple properties).