Apple doesn't have huge sales volume for Macs because of macOS and their astronomical pricing schemes, but it's not because of the hardware. Macbooks are easily the best laptops you can buy for most purposes, and they have been since the M1 came out. That has never been true of Apple computers before.
It's because of the hardware. For mobile Apple is competitive, for desktop applications they don't even show up on most benchmarks next to AMD/Nvidia hardware.
For example, you have to scroll beneath last-gen laptop GPUs before you can find any Apple hardware on the OpenCL charts: https://browser.geekbench.com/opencl-benchmarks