Series X controllers still work this way. Takes standard-ass AA batteries, including rechargeables; or you can buy a bespoke charge pack[1] which actually supports charging while in the controller.
[1] https://www.xbox.com/en-US/accessories/batteries-chargers/pl...
I really wish more devices went this way. In devices these days the thing that will fail first, long before other components, is usually the battery. It seems disingenuous of manufacturers to claim that rechargeable batteries are good for the environment and then ship devices without user replaceable battery packs.
And, if you use good quality 2500mAh rechargeable AAs, those controllers go forever between charges.