My Xbox 360 controllers are still in use. Meanwhile, I've resigned myself to never using any PlayStation controllers for more than three or four years.
AA and AAA batteries are great. I wish using them weren't considered a negative by many hardware reviewers.
You can get replacement parts for PS controllers, although they can be rather fidgety to open up.