logoalt Hacker News

Jenssontoday at 10:33 AM2 repliesview on HN

Why does it sound horrible to have your code reviewed quickly? There is no reason for reviews to wait a long time. 4 hours is already a long time, it means you can wait to do it right before you go home or after lunch.


Replies

duskdozertoday at 11:00 AM

Why would I care if my code is reviewed quickly? If the answer is some variant of "I get punished if I don't have enough changes merged in fast enough," that's not helping. From the other side, it's having someone constantly breathe down your neck. Hope you don't get in a flow at the wrong time and need to break it so Mr. Lumbergh doesn't hit you up on Teams. It just reeks of a culture of "unlimited pto," rigid schedules, KPI hacking, and burnout.

show 1 reply
anonymarstoday at 12:08 PM

It sounds horrible to be interrupted constantly. I can't imagine they'd be particularly thorough reviews

show 1 reply