logoalt Hacker News

grey-areayesterday at 8:40 PM2 repliesview on HN

Was 14k lines carefully reviewed? Seems unlikely.


Replies

joshkelyesterday at 10:10 PM

Considering the many hundreds of technical comments over at the PR (https://github.com/nodejs/node/pull/61478), the 8 reviewers thanked by name in the article, and the stellar reputations of those involved, seems likely.

show 2 replies
vinnymactoday at 2:05 AM

I carefully review far more than 14k LoC a week… I’m sure many here do. Certainly the language you write in will greatly bloat those numbers though, and Node in particular can be fairly boilerplate heavy.