logoalt Hacker News

pull_my_fingertoday at 12:29 AM2 repliesview on HN

When you review code, do you spend 2 minutes per line? That seems like a huge exaggeration of effort required


Replies

grey-areatoday at 6:47 AM

Depends - if it is from a human I find I can trust it a lot more. If it is large blobs from LLMs I find it takes more effort. But it was just a guess at an average to give an estimate of the effort required. I’d hope they spent more than 2 mins on some more complex bits.

Are you genuinely confident in a framework project that lands 19kloc generated PRs in one go? I’d worry about hidden security footguns if nothing else and a lot of people use this for their apps.

seattle_springtoday at 1:49 AM

I probably review about 1k LoC worth of PRs / day from my coworkers. It certainly doesn't take me 33 hours (!!) to do so, so I must be one of those rockstar 10x superhero ninja engineers I keep hearing about.