logoalt Hacker News

hombre_fataltoday at 1:07 PM1 replyview on HN

Okay, I'm looking at it. Now what?

This file is exactly what I'm talking about.

Take the loadInitialMessage function: It's encumbered with real world incremental requirements. You can see exactly the bolted-on conditionals where they added features like --teleport, --fork-session, etc.

The runHeadlessStreaming function is a more extreme version of that where a bunch of incremental, lateral subsystems are wired together, not an example of superfluous loc.


Replies

mpalmertoday at 5:09 PM

The file is more than 5000 lines of code. The main function is 3000. Code comments make reference to (and depend on guarantees in connection with) the specific behavior of code in other files. Do I need to explain why that's bad?

show 1 reply