the writeup is helpful but i'd want to see how it handles edge cases