alt Hacker NewsThese commits reaching the reviewer are a sign of either not knowing how to use git or not respecting their time. You clean things up and split into logical chunks when you get ready to push into a shared place.
Replies
croemer • today at 10:58 AM
What if the shared place is the place where you run a bunch of CI? Then you push your work early to a branch to see the results, fix them etc.
➕ show 2 replies
zaphirplane • today at 10:55 AM
What are examples of better ones. I don’t get the let me show the world my work and I’m not a fan of large PR
➕ show 1 reply
yokoprime • today at 10:58 AM
Haha, good luck working with a team with more than 2 people. A good reviewer looks at the end-state and does not care about individual commits. If im curious about a specific change i just look at the blame.
➕ show 4 replies
Why would the reviewer look at the commit messages instead of the code?
1. Open PR page in whatever tool you're using
2. Read title + description to see what's up
3. Swap to diff and start reading through the changes
4. Comment and/or approve
I've never heard anyone bothering to read the previous commit messages for a second, why would they care?