alt Hacker News> A good reviewer looks at the end-state and does not care about individual commits.
Then I must be a bad reviewer. In a past job, I had a colleague who meticulously crafted his commits - his PRs were a joy to review because I could go commit by commit in logical chunks, rather than wading through a single 3k line diff. I tried to do the same for him and hope I succeeded.
Replies
mgfist • yesterday at 12:34 PM
Why are those not just separate PRs? Or if they really needed to be merged at once - they should still be separate PRs but on a feature branch
➕ show 1 reply
KptMarchewa • yesterday at 12:12 PM
Split the PR rather than force me to wade through your commit history. Use graphite or something else that allows you to stack PRs.
➕ show 1 reply
And then someone comments on a thing, they change it and force-push another "clean" history on top and all of your work is wasted because the PR is now completely different =)