If anything, Nio battery swap stations would allow car users to swap to newer types of battery as they become available. I say this knowing Nio is one of CATL's most important partners[1].
[1] https://eletric-vehicles.com/catl/catl-calls-nio-an-irreplac...
That'd be an interesting situation. They'd probably replace their fleet of batteries gradually, so with each swap sometimes you'd get upgraded, sometimes downgraded. Your range and home charging curves would change with the batteries, and Nio would have to update the battery management software when it puts in a different battery type.
But over time, you'd get upgraded on average without having to pay for a new battery, as long as Nio kept updating to keep its batteries competitive.
In a well designed urban environment where cars have space for 2-3 modular batteries with swapping capabilities, I see no reason why taxis etc. need to carry battery payload > 150 km of range needed for local use, which would mean better fuel efficiency as well. Battery swapping done right is integral to this