logoalt Hacker News

suzzer99today at 3:59 PM3 repliesview on HN

100%. I don't think any senior programmer ever looks at another developer's code and says, "Oh yeah, that's just the way I'd do it."


Replies

cortesofttoday at 4:07 PM

But I assume you don't go and change all your co-workers code just because they didn't do it how you would have done it?

show 1 reply
hirvi74today at 4:07 PM

I concur, and I think that is one of the most difficult aspects of reviewing another's code. It's difficult for me to sometimes differentiate between what is acceptable vs. what I would have done. I have to be very conscious to not impose my ideals.

ai_slop_hatertoday at 4:04 PM

So you are going to waste everyone's time getting another developer to write code the way you want? This resonates with me because at my company I get this all the time. At that point, you might as well close my PR and do it yourself, whatever way you want. I really like the advice from the book 0 2 1, to assign different areas of responsibility to people, so that there is no conflict.

show 1 reply