logoalt Hacker News

triceratopstoday at 2:29 PM2 repliesview on HN

Admirable effort. But why did you have to do it in one PR?


Replies

stronglikedantoday at 2:34 PM

> almost every single thing we were doing had to use the library function instead of the one we wrote

show 1 reply
Neywinytoday at 2:41 PM

As per the other person's comment, yeah basically I could have broken it up but it would've been an arbitrary demarcation. I just deleted our functions and fixed everything that yelled. Admittedly that could've been one and then leveraging the libraries better could've been another, but they would've been 2 PRs that changed almost every line. So done as one to mitigate review time.

show 2 replies