I think it should always be disclosed. Even when they aren't explicitly advocating for a direct benefit to their company, their overall analysis is colored by their interests. The defense industry is going to amp up risks of an aggressor, downplay the risk of appearing to be aggressive, downplay non-military foreign policy strategies etc. Allow the defense industry to influence how we think about foreign events is certainly going to influence how we think about policy and spending.