While the point is valid, the upside still isn't practically infinite; humans intuitively do something close to hyperbolic discounting for future returns (I assume evolution did this because of the possibility of black swans but it isn't talking).
The easy version of this is to value a company over the next 20 years of profits. The first half of that time horizon, I don't see much changing at all outside of Starlink subscribers. They've only got ~5 Mars launch windows in any given decade, and while their design philosophy is great for LEO where launch windows are daily, launching rockets to see what fails is exactly wrong for Mars.
OTOH, now to 2036, there's at least a chance AI goes boom. Perhaps even one of Musk's AI. Great for the overall economy (at least right up until it changes the economy so much that capitalism looks as obsolete as feudalism looks today, which may or may not be in that horizon), but even if it's the next industrial revolution, there's so much competition there that I expect everyone's profit margins to be almost nothing. And conversely, if any one of them does appear to be massively dominant, in comes an anti-trust case (who remembers Standard Oil?)
Same with rockets, though a "rocket boom" is perhaps an unfortunate phrasing. He finds a way to make more money than expected, just like he's already doing with Starlink? Great. Industrial espionage is a thing, and even if it wasn't, China's not got a problem with the state funding businesses to simply re-discover everyone else's secret sauce. US companies and residents may find themselves restricted from using the fruit of that work, but most of the world will just buy what's cheapest.
Still, as I said, your point is valid.
Starship has already made it to orbit multiple times. It's likely that it will be ready to go operational in well under a decade. As we're speaking of upside potential, let's just assume the aspirational goals are hit - and you end up seeing $10-$20/kg to space. You've just revolutionized not only space, but all transport on Earth as those prices are less than most terrestrial shipping options, and it can be delivered anywhere on Earth in a matter of minutes.
The implications of that are quite difficult to even fathom because again this is one of those things where I feel like we're trying to predict the economics of the internet before the first cable had been laid. But the one thing that can be very safely said is that the impact would be revolutionary.
And that is completely ignoring space when the whole point of Starship is being able to get 100+ tons to the Moon or Mars, which again revolutionizes those domains first in terms of size, but vastly more importantly - in terms of cost as well. This opens the door to viable private development on the Moon and Mars (to say nothing of space itself). And again the implications of this are very difficult to predict, but it would also certainly be revolutionary.
---
The competition issue you've brought is, in my opinion, one of the most viable concerns. If America can get stuff to orbit for $20/kg then it feels like China always finds a way to do it for $0.20/kg. But the reality is that SpaceX's secret sauce isn't all that secret. Their exact alloys, general construction specs, and more are all public knowledge. Many have tried, including with vast resources and wits behind them, and all have failed.
China is almost certainly going to be the #2 player and their Long March 9 [1] is their attempt to clone the Starship, but for now it's vaporware. And to actually get these things out onto the launch pad isn't the endgame, but just the beginning of the race. They are almost certainly years behind SpaceX, and the distance is likely increasing over time as SpaceX shows no signs of slowing down, and now has no funding constraints whatsoever.
[1] - https://en.wikipedia.org/wiki/Long_March_9