this should we do this or no this is not right