I'm not saying that non-citizens have identical political rights to citizens or that temporary residence can never end.

What I'm saying is that persons legally present in a country should not be penalized as a group based on nationality, religion or any other broad cultural polling/averages rather than individual conduct and due process of the law.

Citizenship can allow for some distinctions but it does not make non-citizens mere guests whose rights can be revoked at will. A state can regulate immigration but it still has the moral/ethical and legal duties to avoid arbitrary and discriminatory treatment of all persons under its jurisdiction, especially toward people it has already admitted lawfully.

There should never be 'second class' persons under the law and rights should not be "subject to changing political winds" as you seem to be suggesting, because that would mean there are no such thing as universal human rights which would put all persons (citizen or otherwise) in danger of losing their rights at the whims of the state or the majority.