logoalt Hacker News

glerktoday at 12:31 AM2 repliesview on HN

> stylelint beeps you can't just pass hex colors directly, that color is not in our design system, you need to write a design doc for custom color tokens and get approval from the frontend platform team, open a PR in their repo, make sure you have storybook tests covering all the color <cross product> button variants, ask in their slack channel for approve, ask their manager, wait. someone from their team leaves a comment: "we should make this an approved custom colors enum not a string, so if you want to add custom colors you also have to update this enum", fix the PR, staff engineer from sister team drive by request for changes: "we are currently implementing custom themes and changing colors will be done through the ColorSwatch service", ask for timelines, "maybe next week behind a feature flag", give up, close the PR, open a new PR with "stylelint-disable", force-merge it.


Replies

handoflixuetoday at 4:16 AM

Your PR has been denied for not including a Ticket Number. Please make sure all bugs are assigned a Ticket and properly T-Shirt Sized at the next Scrum! Reminder: due to the holiday, the next Scrum Meeting will be in 3 weeks.

drawfloattoday at 6:10 AM

Probably should be telling the design team to actually use the colours that are approved then.