logoalt Hacker News

bobbylarrybobbytoday at 3:35 AM2 repliesview on HN

Do you really care if someone forgot to format before committing? They can always squash and push locally if they need to.


Replies

locknitpickertoday at 4:30 AM

> Do you really care if someone forgot to format before committing?

Not OP but yes I definitely do. If you expect others to spend time reviewing your code, you are obligated to start off by reviewing it yourself. Posting a mess helps no one and makes code harder to audit.

LtWorftoday at 6:38 AM

I really really really do not want the autoformatter stuff happening in the same commit as where the real thing happens. I don't care to review if the autoformatter is working properly.