logoalt Hacker News

27183yesterday at 6:53 PM3 repliesview on HN

We have a pretty strong existence proof... the thing happened in production. Unless they have some means to override a failing test and scp broken shit to prod, there wasn't a test.


Replies

chasd00yesterday at 7:32 PM

why would a test setting unit to Bytes fail and not MB, KB, or GB, and so on? That's like trying create a unit test for email opt-in, both true and false are valid values. It's up to the user to select the right one.

show 1 reply
8noteyesterday at 9:23 PM

missing canaries more likely?

insufficient tests that dont assert on the right things?

the existence of a test doesnt mean it catches the right thing

based on the description, id bet the COE action item will be to do a migration that enforces units are passed at the billing service level

theres no good reason for the billing service to make up its own units.

show 1 reply
nulloremptyyesterday at 7:05 PM

Technically, there could be a test. It could just be wrong!

show 1 reply