In the USA they are overwhelmingly public and are desperate for customers.
The handful of private ones near me are also desperate for new members, and several country clubs have ended up closing. Considering some of the golf courses that have closed around me ended up being converted into Amazon distribution facilities, I am not terribly excited about the idea of more golf courses closing.
Were those private lands/properties? Because in my country a lot (if I can't say 'most') are actually on public land with weird and disgustingly cheap leases which can be closed at a finger snap but somehow very few Govts have tried it because every Govt have ministers (and of course bureaucrats) who are members there or made members there, and then there are their kids and families etc. So no they can't be turned into building constructions really, I mean assuming the limits of corruption in my country. Because technically anything can be sold if we go down that way. Also, my city is reclaiming lakes, demolishing illegal constructions and parks are also being reclaimed and cleaned up etc.
Not perfect, far from it, but it's a start and no, that Amazon Warehouse thing I am not expecting to see here. People are divided strongly on religious and ideological lines here but everyone's tempers run high whenever Govt tries touching a public land, green patch, and now we just take matters into our hands whenever that happens.
In the USA as elsewhere golf courses are incredible wastes of water and false green spaces that would function better as green spaces were they actually parks open to the public they serve the wealthy. What is different is that in the US there is very little real (operational) worry about waste of water (or other resources) - at least compared to other places - and there is lots of space compared to other places.