logoalt Hacker News

mort96today at 6:35 PM1 replyview on HN

Merging a PR by drive-by contributors is far from trivial. As the maintainer, you become responsible for the other person's code for all eternity; it's on you to read it, understand it, update it when stuff around it changes, and fix it when it breaks.

Not a problem for obviously-correct changes of a couple of lines, but most PRs aren't like that.


Replies

nazgulsenpaitoday at 6:58 PM

I understand and that's a fair point. I should have phrased that differently, in that the PRs for features were waiting to be merged. I'm sure merging into a codebase as... storied? as xorg is no small task.