logoalt Hacker News

jakeasmithlast Tuesday at 8:58 PM2 repliesview on HN

Author here, happy to answer any questions. I never imagined a polyfill for http_build_url would gain so much traction. After 12 years, deprecating it feels like the right move, especially given the new options from the community and PHP itself.


Replies

layer8today at 9:42 AM

I’d say the deciding factor is that it has bugs where both fixing and not fixing them can have a negative impact. If there were no known bugs and there was no harm in using it, I’d probably just leave it there and not disturb anything, given that its use is so widespread, and instead merely note in the documentation that its purpose has become obsolete.

HackerThemAlltoday at 8:43 AM

The JavaScript world is littered with stuff comparing to which your patch seems like a complex project. See those examples:

https://www.npmjs.com/package/is-odd

https://www.npmjs.com/package/is-even

https://www.npmjs.com/package/left-pad

https://www.npmjs.com/package/is-whitespace-character

https://www.npmjs.com/package/isarray

show 1 reply