Yes, but public transit does create value - the question is who captures it.

BART likely created huge profits for people who owned land in the areas it services - house prices and rents would have increased substantially. Public investment, private profits. Subsidies in the form of low-cost fares like this are just further welfare for the landowners.

Interestingly, about a third of BART's cost was acquiring land - if/when that same land is cleared and sold on market, the project would have operated at an enormous profit. Certainly, BART's current assets would far exceed 'total fares collected'.