> String theory had a generation of great science communicators writing its books and singing its praises...

I would argue that has done more harm than good. Strong media personalities shouting "the next big breakthrough is here!" followed by 25 years of zero practical results have not done good things for public perception of field of physics. A layperson could be mistaken for assuming the field is literally regressing.