logoalt Hacker News

otikik • today at 9:11 AM • 1 reply • view on HN

I had a similar impression. It feels "not idiomatic". I disagree on the diagostic though - I think parenthesis-free calls are not what define what idiomatic lua is.

To me it is more about expressiveness and usage of basic language features. For example here's how a text field is set up currently.

           ito.TextField(draft)
                :label("Name")
                :focused()
                :on_submit(function(value)
                    if value:match("%S") then
                        phase.value = "review"
                    end
                end)
                :on_cancel(function()
                    phase.value = "choose"
                end),

The field is created on the first line, and then altered further with subsequent method calls that alter it. This reads like someone very used to Rust (and its Builder pattern) and then translating it verbatim to Lua. A more native Lua interface for me would look like this:

           ito.TextField(draft, {
                label = "Name",
                focused = true,
                on_submit = function(value)
                    if value:match("%S") then
                        phase.value = "review"
                    end
                end,
                on_cancel = function()
                    phase.value = "choose"
                end),
           })
As in: just pass a table to the builder. And if they ned to modify it later, they can just do:

           some_textfield.on_cancel = <some other function>
No need to "guard" the internal table with those extra methods.

Replies

cat-whisperer • today at 9:25 AM

that’s fair; I was suggesting something even more drastic than this https://github.com/uji-labs/ito/issues/4

maybe it’s a bad idea :X