logoalt Hacker News

darkwi11ow • today at 3:17 PM • 0 replies • view on HN

Yeah, I have extensive collection of prompts for reviews and usually run 3-5 (automated) review takes on large sets of changes before doing eyeball reviews. Auto reviews indeed find many obvious bugs, but they usually slip through things that are less obviously stupid but are bad conceptually, for example, using persistence / queue / repository in a place where set of pure functions would be enough; or vice-versa, not persisting the state that must be persisted for reasons, etc.

Another problem is that review changes can easily introduce new issues, so my review prompts go like that: if you find outright shit, fix it right away, but if you have slightest concern, just write your ideas and suggestions in the review and let me decide then. I try from time to time to omit the "slightest concern" part and make agent do all the shit it wants, and usually end up reverting those changes.

But as the sibling comment said, not all code needs quality and indeed I skip some code too, like user playwright journeys -- I only need one auto review pass to verify they indeed test things according to a doc, and I'm fine not reading them. Not all code like that though, some stuff would wreck havoc later if its not looked at.