logoalt Hacker News

lukeify • yesterday at 11:01 PM • 3 replies • view on HN

> Something is a small-change if it meets all of these criteria it is less than 1,000 lines of code

Only my personal view but even 1000 LoC is not a "small change".


Replies

andreimackenzie • today at 12:01 AM

This struck me too, but I think it is intentionally a high limit to prevent problems like relatively low impact/high LoC tests from tipping a small change into a large one. That would encourage gamification like skipping useful scenarios to keep a change "small".

The other criteria are more important.

skydhash • yesterday at 11:18 PM

Yep a small changes is one computer screen of diff (36 to 48 lines) excluding generated changes (lock files, formatted files,…)

➕ show 2 replies
jibalt • today at 12:33 AM

AND, not OR.

➕ show 2 replies