"War on X" was originally a way of mocking Richard Nixon's "War on drugs". Everyone thought it was a stupid term at the time, for the reasons you list. So we started talking about the "war on cheap beer", the "war on disco music", etc (I was in college at the time). I'm not sure when people started using the term seriously.