logoalt Hacker News

jayknight • today at 1:42 AM • 1 reply • view on HN

I mean if it's a code review, you gotta review the code.


Replies

johannes1234321 • today at 1:50 AM

Yes, but code can be presented in different ways. This depends of course to a degree on the submitter (large changeset touching a lot of files or smaller change sets building upon each other?) but also could be presented differently (highlighting changes to data structures, identifying core parts of code and helper routines - lots of room for imagination)

Also mind: one doesn't only have to review changes code, but also review what hasn't been changed (are preconditions of other code still met?)

➕ show 1 reply