If anything, Nio battery swap stations would allow car users to swap to newer types of battery as they become available. I say this knowing Nio is one of CATL's most important partners[1].

[1] https://eletric-vehicles.com/catl/catl-calls-nio-an-irreplac...

We should always take marketing number with a huge grain of salt, so the 10 to 98% in 7 minutes remain to be seen. Also, there is the question of if it lowers the battery lifespan faster than charging at lower power. It is does, there might still be a point in battery swap, especially for public transport systems (for bus). A public transit operator might want to have more battery than vehicle, so that they can rotate the battery regularly and charge them at lower power, to diminish and distribute the wear on battery. But that's obviously a big if and a more niche usage.