logoalt Hacker News

Neywinytoday at 2:12 PM2 repliesview on HN

I was (almost) just that guy for one PR. Removed something like 20% or more of the codebase by leveraging the libraries and external tools we already had in use better, but it meant almost every single thing we were doing had to use the library function instead of the one we wrote. But assuming you have good regression tests and linters, so you know the code works and it's not terrible, the review should be more about overall high level quality instead of poring over every character to check correctness. It was still a pain to review, though


Replies

jt2190today at 2:24 PM

You’re not an example of what we’re taking about here. Congratulations!

A better example would be if you’d changed the behavior of the library as you did this work, and the library changes introduced hard-to-detect bugs across the application.

show 1 reply
triceratopstoday at 2:29 PM

Admirable effort. But why did you have to do it in one PR?

show 2 replies