logoalt Hacker News

duskdozertoday at 10:20 AM3 repliesview on HN

That sounds horrible. I don't know how people stand to work in those conditions.


Replies

titanomachytoday at 11:08 AM

Well, there's a reason I'm no longer working there :)

But some people will put up with a lot for half a million dollars a year.

show 1 reply
Jenssontoday at 10:33 AM

Why does it sound horrible to have your code reviewed quickly? There is no reason for reviews to wait a long time. 4 hours is already a long time, it means you can wait to do it right before you go home or after lunch.

show 2 replies
IshKebabtoday at 11:18 AM

Sounds kind of amazing to me. 4 hours is a bit ridiculous, but I wish we had some kind of automated system to poke people about reviews so I don't have to. It's doubly bad because a) I have to do it, and b) it makes me look annoying.

My ideal system (for work) would be something like: after 2 days, ask for a review if the reviewer hasn't given it. After a week, warn them the PR will be auto-approved. After 2 weeks, auto-approve it.